Fix test-CI #6909
Merged
Fix test-CI #6909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing holoviews test is because of changes made in holoviz/holoviews#6256 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6909 +/- ##
===========================================
+ Coverage 38.42% 81.56% +43.13%
===========================================
Files 308 319 +11
Lines 45062 46915 +1853
===========================================
+ Hits 17315 38264 +20949
+ Misses 27747 8651 -19096 ☔ View full report in Codecov by Sentry. |
philippjfr
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conda-forge now has
playwright, though they patched it to remove the download option, and it only works on the UNIX system for now. For now, I will keep using the one from the Microsoft channel. It does seem like the conda-forge equivalent is calledpython-playwright.Also, fixing the error shown in #6902
I think the failing test in
test_param_generatoris because we don't have an event loop, which takes time to start on CI, therefore missing thewait_untiltime.